Opened 4 years ago

Closed 9 months ago

#4039 closed change (rejected)

Introduce "suppress_antiadblocklist" preference

Reported by: greiner Assignee:
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: sporz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We need to ensure that the anti-adblock list is always installed to avoid issues such as #3772 which caused millions of users to end up not having it added during the installation. To ensure that it's not being added again after it was removed, we could introduce a preference which could also be reused by administrators to prevent the filter list from being added on installation in the first place.

What to change

  • Introduce "suppress_antiadblocklist" preference with a default value of false
  • Set preference to true when user removes the anti-adblock filter list
  • Add the filter list on startup if it isn't installed and the preference is false
  • The filter list should not be added when updating from a version that didn't have this preference yet to avoid overriding the users' choice in case they intentionally removed it

Change History (2)

comment:1 Changed 9 months ago by sporz

I suggest to close this due to being obsolete: AFAIK this is no longer a standard feature of ABP.

comment:2 Changed 9 months ago by greiner

  • Resolution set to rejected
  • Status changed from new to closed

This feature is still part of the extension because we haven't yet allocated resources to remove it. But you're right that this ticket is no longer applicable because we're still planning to remove this feature so I'm closing it as rejected.

Note: See TracTickets for help on using tickets.