Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#4041 closed defect (fixed)

Missing engine startup synchronization causing 'blocker not available' message

Reported by: rjeschke Assignee: rjeschke
Priority: P1 Milestone: Adblock-Plus-for-Samsung-Browser-1.0.3
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: mario Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29341398/

Description

The content blocker's underlying engine is initialized asynchronously. Now, when the content blocker needs to be restarted, because SBrowser is asking for filters, then it is possibly that engine initialization isn't finished when SBrowser asks for the filters. This results in an error message thrown by us.

Currently the engine-initialized callback is executed on the UI thread, so it is not possible to wait for initialization in the content provider callback.

We need to implement two changes to fix this issue:

  1. allow the engine-initialized callback to be executed on the UI thread and a general purpose looper (possibly just a boolean for selecting which one to use)
  2. wait for engine initialization in the content provider callback

Change History (7)

comment:1 Changed 4 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplussbrowser/rev/7f85855c3d8f

comment:3 Changed 4 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • The error message below no longer occurs:
ContentBlockerContentProvider: Engine not initialized
SBrowserProxyHandler: getMDMProxy() : MDM proxy[]
System.err: java.io.FileNotFoundException: Engine not yet initialized
  • The error message in Sbrowser also no longer occurs 'blocker of unwanted content not available. Please contact the developer for details.'

Adblockplussbrowser-1.0.3-20160513123700-signed
Samsung Galaxy S5, S6
Android 5.0.1
Android 6.0

comment:5 Changed 4 years ago by mario

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.0.3

comment:6 Changed 3 years ago by rhana@…

Hi @rjeschke! We have a user who is still receiving this error with ABP for Samsung Browser v1.0.3. She initially reported this to us because she was receiving the error with AdBlock for Samsung Internet (both the original version and our last update, 1.2). Yesterday we had her install ABP 1.0.3 from Google Play. The error is still occurring. Is there something more she needs to do?

Last edited 3 years ago by rhana@… (previous) (diff)

comment:7 Changed 3 years ago by scheer

  • Cc mario added
Note: See TracTickets for help on using tickets.