Opened 4 years ago

Closed 3 years ago

#4045 closed change (fixed)

Add tests to the CMS

Reported by: sebastian Assignee: jsonesen
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: jsonesen, kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345468/

Description (last modified by sebastian)

Background

Our CMS is used to generate the static content for websites like https://adblockplus.org (source) and https://eyeo.com (source). It can be used in two modes, either to generate static files, or to run as a development server generating pages on demand, for more details see the README.

So far we have no automated tests for the CMS, hence future changes are quite risky and difficult to test. In particular, with the current consideration to migrate this code to Python 3, we'd need tests first.

What to change

Write a simple dummy website that uses every feature of the CMS. The tests then should generate the static files into a local folder as well as running the development server, comparing both the the generated files and the content delivered by the server against the excepted result. Also add a tox script to run those tests.

Change History (5)

comment:1 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:2 Changed 4 years ago by jsonesen

  • Owner set to jsonesen

comment:3 Changed 3 years ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by kvas

A commit referencing this issue has landed: Issue - 4045 Add CMS Test Suite.

Unfortunately I missed the wrong format of commit message and our commit hook is too forgiving :|

comment:5 Changed 3 years ago by jsonesen

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.