Opened 12 months ago

Closed 20 hours ago

#4046 closed change (worksforme)

Set up proguard

Reported by: rjeschke Assignee: jwangenheim
Priority: P2 Milestone:
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: diegocarloslima Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

adblockplussbrowser does currently not use proguard for minimizing APK size.

What to change

Enable and configure proguard.

Change History (3)

comment:1 Changed 3 days ago by jwangenheim

  • Owner set to jwangenheim

comment:2 Changed 41 hours ago by jwangenheim

  • Cc diegocarloslima added

Since @diegocarloslima migrated the project to Gradle / Android Studio, we use the getDefaultProguardFile('proguard-android.txt') method, which gets the default ProGuard settings from the Android SDK tools/proguard/ folder.

As we currently don't use any libs (except android.support:support-v4), the default ProGuard rules are okay for this project. The APK gets shrinked from 1.6 to 1 MB.

So I think this issue can be marked as resolved.

Last edited 22 hours ago by jwangenheim (previous) (diff)

comment:3 Changed 20 hours ago by diegocarloslima

  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.