Opened 3 years ago

Closed 3 years ago

#4050 closed defect (fixed)

First run page subscription toggles are commented out

Reported by: Ross Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

ABP Edge 0.9.1.0
Windows 10 / Edge

How to reproduce

  1. Install ABP for Edge.
  2. Scroll down the first-run page.
  3. Observe no toggles are displayed to the right of the extra subscriptions.

Observed behaviour

The toggle switches next to the extra subscriptions (like social/malware blocking) on the first-run page are commented out in the first-run page source in 0.9.1.0.

Expected behaviour

Toggles to be displayed / working.

Change History (4)

comment:1 Changed 3 years ago by Ross

It was mentioned we did not create this build, MS did. So this is more a tracking issue to ensure that the toggles are back before proper release.

comment:2 Changed 3 years ago by sebastian

  • Cc sebastian added
  • Sensitive set

Feel free to keep the issue open for yourself. However, this functionality isn't supposed to work in the current version provided by Microsoft. And future versions based on our upstream code won't have their patches.

comment:3 Changed 3 years ago by sebastian

  • Sensitive unset

comment:4 Changed 3 years ago by sebastian

  • Resolution set to fixed
  • Status changed from new to closed

This should be fixed in 0.9.3 and 0.9.4.

Note: See TracTickets for help on using tickets.