Opened 4 years ago

Last modified 4 years ago

#4052 closed defect

Cannot add subscriptions with Chrome 30 — at Version 2

Reported by: kzar Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, Ross, scheer Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29342814/

Description (last modified by kzar)

Environment

Chrome Version 30.0.1599.66
Adblock Plus development build 1.11.0.1604

How to reproduce

  1. Open the options page
  2. Attempt to add a new filter list subscription

Observed behaviour

Nothing happens, the subscription is not added. This is shown in the options page console:

Uncaught Error: Invocation of form runtime.sendMessage(object, undefined, null) doesn't match definition runtime.sendMessage(optional string extensionId, any message, optional function responseCallback) schemaUtils:113
normalizeArgumentsAndValidate schemaUtils:113
(anonymous function) binding:307
(anonymous function) options.js:59
addSubscriptionClicked options.js:376
f.event.dispatch jquery-1.7.1.min.js:3
h.handle.i jquery-1.7.1.min.js:3

Expected behaviour

The subscription to be added, with no exception in the console.

Notes

This is being caused when ext.backgroundPage.sendMessage is called with a callback of undefined. It works correctly when the callback is omitted instead.

Change History (2)

comment:1 Changed 4 years ago by sebastian

  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed 4 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.