Opened 4 years ago

Closed 3 years ago

#4053 closed change (fixed)

Review arm configuration of compiling of v8 and libadblockplus for android

Reported by: sergz Assignee:
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd, rjeschke, asmirnov Blocked By:
Blocking: #1197 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



I'm trying to compile libadblockplus and v8 with updated v8 (#1197, for android and I have several questions.

Why do we have this particular values for the following parameters

  • arm_neon=0
  • armv7=0
  • arm_fpu=off vfp3=off arm_float_abi=default?

I need to specify arm_version and arm_thumb, it seems that arm_version=7 and arm_thumb=1 works but does it fit our requirements and what values should I use there?

-mfpu=off is not supported, so so far I'm trying with arm_fpu=default (arm_version=7) and the compilation passes.

Additional info

  • René told that some of those parameters above are legacy, so we probably should review them.
  • v8 likely requires support of floating point operations.
  • Some of the parameters depend on the lowest version of ARM which we want to support, so what is that lowest version?

What to change

After answering the questions above, update that issue with the proper description with the new values which we want to use.

Change History (1)

comment:1 Changed 3 years ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed

Since #4907 is landed, it can be closed.

Note: See TracTickets for help on using tickets.