Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4054 closed defect (fixed)

Element hiding rules continue to be matched after being removed

Reported by: kzar Assignee: kzar
Priority: P1 Milestone:
Module: Core Keywords:
Cc: sebastian, trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29342837/

Description (last modified by kzar)

Environment

adblockpluschrome after b7884247c8ed

How to reproduce

  1. Enable EasyList and run this code in the console:
var ElemHide = require("elemHide").ElemHide;
ElemHide.getSelectorsForDomain("www.extremetech.com");
  1. Disable EasyList and run the same code again.

Observed behaviour

The results are the same, an array of around 17,000 selectors.

Expected behaviour

The second time a much shorter/empty array should be returned.

Notes

When making the changes for #235 we forgot to remove filters from the filtersByDomain lookup again.

Change History (8)

comment:1 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by trev

  • Component changed from Platform to Core

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluscore/rev/b791dfaa66c6

comment:4 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by kzar

  • Description modified (diff)

comment:6 Changed 3 years ago by kzar

  • Description modified (diff)

comment:7 Changed 3 years ago by kzar

  • Description modified (diff)

comment:8 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Opera 36 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.