Opened on 05/20/2016 at 12:12:21 PM

Closed on 05/24/2016 at 08:04:47 AM

#4055 closed change (fixed)

Add unit tests for ElemHide.getSelectorsForDomain

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Core Keywords:
Cc: trev Blocked By:
Blocking: #4057 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



adblockpluscore/lib/elemHide.js contains a function getSelectorsForDomain which is used by adblockpluschrome to apply element hiding rules to webpages. It's a performance bottleneck currently and with #235 we are looking to improve that. Unfortunately it is not a trivial function and regressions (see #4054) are easy to miss.

What to change

Add unit tests for getSelectorsForDomain. Test adding of filters, removal of filters, getSelectorsForDomain itself. Take care to test both rules that don't apply to a domain such as, and rules that are overwritten by filter exceptions.

Attachments (0)

Change History (5)

comment:1 Changed on 05/20/2016 at 12:14:36 PM by trev

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 05/20/2016 at 03:12:32 PM by kzar

  • Blocking 4057 added

comment:3 Changed on 05/22/2016 at 04:44:15 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 05/24/2016 at 08:03:25 AM by abpbot

A commit referencing this issue has landed:
Issue 4055 - Test ElemHide.getSelectorsFordomain

comment:5 Changed on 05/24/2016 at 08:04:47 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.