Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#4057 closed change (fixed)

Further improve ElemHide.getSelectorsByDomain() performance

Reported by: kzar Assignee: kzar
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: sebastian, trev Blocked By: #4055, #4067
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29342830/

Description

Background

Following the work in #235 to improve the performance of ElemHide.getSelectorsByDomain() we want to go further. With a proof of concept already performing > 3x faster than our existing implementation there's clearly room for improvement.

What to change

Further improve on the proof of concept we already have, simplifying it where is possible without a performance hit.

Change History (5)

comment:1 Changed 4 years ago by kzar

  • Status changed from new to reviewing

comment:2 Changed 3 years ago by trev

  • Blocked By 4067 added

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4057 - Speed up ElemHide.getSelectorsForDomain

Last edited 3 years ago by kzar (previous) (diff)

comment:4 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Element hiding seems to be working as expected (including FF hit statistics) except in Firefox 38-40, which is open as #4198.

ABP 1.12.0.1622
Chrome 30 / 40 / 50 / Windows 7
Opera 19 / 36 / Windows 7
Safari 7 / 9 / / OS X 10.9 / OS X 10.11

ABP 2.7.3.4184-beta
Firefox 41-45 / Windows 7

Note: See TracTickets for help on using tickets.