Opened 5 years ago

Closed 5 years ago

#406 closed change (fixed)

[meta] The $sitekey option should enable/disable specific filters

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Unknown Keywords: 2014q3, meta
Cc: trev, greiner Blocked By: #431, #432, #433, #434, #698
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by philll)

Background

Currently, the $sitekey option makes it possible to whitelist everything on a site that has the matching private key. It's the only practicable approach for whitelisting a large number of sites, but easy to abuse.

What to change


Change History (17)

comment:1 Changed 5 years ago by fhd

  • Cc trev added

Wladimir, can you go over this and set to ready when you're happy with it?

It looks to me like this can be addressed in Core. If it needs platform specific work, we should turn it into a meta issue.

comment:2 Changed 5 years ago by trev

  • Description modified (diff)
  • Ready set

Changed description to make it more clear. And - yes, this should be a meta issue. There are three parts here: Core, Platform and documentation.

comment:3 Changed 5 years ago by fhd

Can you create the Core/Platform issues for this Wladimir? I think you've got a much better idea of what in particular we need to change in each case. Also note that Platform currently only covers Chrome/Opera/Safari code, meaning we'll also need a Firefox issue if this cannot be changed in Core alone.

comment:4 Changed 5 years ago by greiner

  • Cc greiner added

comment:5 Changed 5 years ago by fhd

  • Priority changed from P3 to P1

Increasing priority, we should get this sorted out as soon as possible.

comment:6 Changed 5 years ago by trev

  • Blocked By 431 added

comment:7 Changed 5 years ago by trev

  • Blocked By 432 added

comment:8 Changed 5 years ago by trev

  • Blocked By 433 added

comment:9 Changed 5 years ago by trev

  • Blocked By 434 added

comment:10 Changed 5 years ago by trev

  • Description modified (diff)

comment:11 Changed 5 years ago by fhd

  • Component changed from Core to Unknown
  • Summary changed from The $sitekey option should enable/disable specific filters to [meta] The $sitekey option should enable/disable specific filters

comment:12 Changed 5 years ago by trev

  • Keywords meta added

comment:13 Changed 5 years ago by philll

  • Description modified (diff)
  • Keywords 2014q3 added

comment:14 Changed 5 years ago by fhd

  • Priority changed from P1 to P2

Reducing priority again, this is planned and not a real blocker.

comment:15 Changed 5 years ago by greiner

  • Blocked By 698 added

comment:16 Changed 5 years ago by sven

  • Keywords changed from meta,2014q3 to 2014q3, meta
  • Platform set to Unknown

comment:17 Changed 5 years ago by greiner

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.