Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#4065 closed defect (fixed)

Subscribe links do not work in Chrome 30

Reported by: Ross Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.12.1-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29342971/

Description (last modified by kzar)

Environment

ABP 1.11.0.1606
Chrome 30 / Windows 7

Also reproduced with 1.10.

How to reproduce

  1. Install extension.
  2. Visit https://testpages.adblockplus.org
  3. Select the "Subscribe" link on the right.
  4. Observe nothing happens.

Observed behaviour

Nothing happens / link seems ignored.

Expected behaviour

The ABP options page to be displayed with the "Add a custom subscription" fields filled in.

Notes

For some reason Chrome 30 thinks that link.search is a blank string, so we need to grab the search part of the URL ourselves.

Change History (8)

comment:1 Changed 4 years ago by sebastian

  • Cc kzar sebastian added
  • Component changed from Unknown to Platform
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 4 years ago by kzar

  • Description modified (diff)
  • Owner set to kzar

comment:3 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by Ross

This also occurs in Chrome 31.

comment:5 Changed 4 years ago by kzar

(We already have a fix for this issue, but will wait until after the release to push.)

comment:6 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
Fixes 4065 - Subscription links on Chrome 30

comment:7 Changed 4 years ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Works as expected now in both Chrome 30 and later.

Chrome 30 / Windows 7
Chrome 35 / Windows 7
Chrome 48 / Windows 7

Note: See TracTickets for help on using tickets.