Opened 4 years ago

Closed 3 years ago

#4068 closed change (fixed)

Redirect trailing-dot hostname requests to use canonical domain name

Reported by: matze Assignee:
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: jsonesen, trev Blocked By: #4069
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29343003/

Description (last modified by trev)

The DNS-notation of i.e. *.adblockplus.org. domains (with trailing dot) is implicitly supported by the protocols and service daemons in use, but can lead to potential issues if not taken explicit care of:

  • Some software does not support the notation
  • Cookies set for either notation are not shared

Thus we should introduce a globally ensured rule in our HTTP-daemon configuration, redirecting any request where Host: $HOSTNAME. to $HOSTNAME without the trailing dot.

Change History (8)

comment:1 Changed 4 years ago by matze

  • Blocked By 4069 added

comment:2 Changed 4 years ago by trev

  • Description modified (diff)

I changed the description slightly as far as cookies are concerned: it's not "may," cookies just aren't shared as per spec - period.

comment:3 Changed 4 years ago by trev

  • Summary changed from Redirect tailing-dot hostname requests to use canonical domain name to Redirect trailing-dot hostname requests to use canonical domain name

comment:4 Changed 4 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by matze

  • Ready set

comment:7 Changed 4 years ago by matze

  • Blocked By 4073 added

comment:8 Changed 3 years ago by matze

  • Blocked By 4073 removed
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.