Opened 6 years ago

Last modified 6 years ago

#406 closed change

The $sitekey option should enable/disable specific filters — at Version 2

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Unknown Keywords: 2014q3, meta
Cc: trev, greiner Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by trev)


Currently, the $sitekey option makes it possible to whitelist everything on a site that has the matching private key. It's the only practicable approach for whitelisting a large number of sites, but easy to abuse.

What to change

The $sitekey option should apply to the URLs matching the pattern part of the filter, not necessarily globally. Adding the $sitekey option to any filter should make sure that the filter only applies on websites that provide the correct private key.

While we're at it, we should also document this.

Change History (2)

comment:1 Changed 6 years ago by fhd

  • Cc trev added

Wladimir, can you go over this and set to ready when you're happy with it?

It looks to me like this can be addressed in Core. If it needs platform specific work, we should turn it into a meta issue.

comment:2 Changed 6 years ago by trev

  • Description modified (diff)
  • Ready set

Changed description to make it more clear. And - yes, this should be a meta issue. There are three parts here: Core, Platform and documentation.

Note: See TracTickets for help on using tickets.