Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4072 closed defect (fixed)

[abp2blocklist] Extra rule created for domain whitelisting filters with only $document type

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Platform Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29344565/

Description

How to reproduce

  1. Run the abp2blocklist tests: npm test

Observed behaviour

Some domain whitelisting tests fail.

Expected behaviour

All tests pass.

Notes

We accidentally OR'd when we should have AND'd, meaning that for whitelisting filters with only the $document content type we accidentally created a second rule.

Change History (4)

comment:1 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4072 - Fix typo in domain whitelisting logic

comment:3 Changed 3 years ago by kzar

  • Priority changed from Unknown to P3
  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed

(Do we need to assign a milestone for abp2blocklist fixes?)

comment:4 Changed 3 years ago by sebastian

If there will be a separate issue for the dependency update which is going to be in the milestone, that's sufficient. Assigning a a milestone to this issue, might even be misleading as this change also effect the lists generated for iOS on the server.

Note: See TracTickets for help on using tickets.