Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4075 closed change (fixed)

Update adblockpluscore dependency to revision 08d73d05cfcd

Reported by: kzar Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-1.12.1-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, Ross, scheer Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29344612/

Description (last modified by kzar)

Background

We recently put more work into improving the performance of ElemHide.getSelectorsForDomain in adblockpluscore. Now we want to include that in adblockpluschrome.

What to change

Update the adblockpluscore dependency to revision 08d73d05cfcd. It will include three changes all related to improving (#4057, #4067) and testing (#4055) ElemHide.getSelectorsForDomain.

Hints for testers

Ensure element hiding filters still work on Chrome with this change.

Change History (5)

comment:1 Changed 3 years ago by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4075 - Update adblockpluscore dependency

comment:4 Changed 3 years ago by kzar

  • Cc Ross scheer added
  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Element hiding still works as expected.

ABP 1.12.0.1622
Chrome 30 / 40 / 50 / Windows 7
Opera 19 / 36 / Windows 7
Safari 7 / 9 / / OS X 10.9 / OS X 10.11

Note: See TracTickets for help on using tickets.