Opened on 05/26/2016 at 12:54:30 PM

Closed on 06/01/2016 at 04:10:32 PM

Last modified on 06/27/2016 at 08:48:01 AM

#4075 closed change (fixed)

Update adblockpluscore dependency to revision 08d73d05cfcd

Reported by: kzar Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-1.12.1-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, Ross, scheer Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by kzar)


We recently put more work into improving the performance of ElemHide.getSelectorsForDomain in adblockpluscore. Now we want to include that in adblockpluschrome.

What to change

Update the adblockpluscore dependency to revision 08d73d05cfcd. It will include three changes all related to improving (#4057, #4067) and testing (#4055) ElemHide.getSelectorsForDomain.

Hints for testers

Ensure element hiding filters still work on Chrome with this change.

Attachments (0)

Change History (5)

comment:1 Changed on 05/26/2016 at 01:06:51 PM by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/26/2016 at 01:10:07 PM by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 06/01/2016 at 04:04:22 PM by abpbot

A commit referencing this issue has landed:
Issue 4075 - Update adblockpluscore dependency

comment:4 Changed on 06/01/2016 at 04:10:32 PM by kzar

  • Cc Ross scheer added
  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 06/27/2016 at 08:48:01 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Element hiding still works as expected.

Chrome 30 / 40 / 50 / Windows 7
Opera 19 / 36 / Windows 7
Safari 7 / 9 / / OS X 10.9 / OS X 10.11

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.