Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4076 closed change (fixed)

Update abp2blocklist dependency to revision 6576f594f0b9

Reported by: kzar Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-1.12.1-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, Ross, scheer Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29344609/

Description (last modified by kzar)

Background

We recently fixed (#4072) a small bug in abp2blocklistis fix in adblockpluschrome.

What to change

Update the abp2blocklist dependency to revision 6576f594f0b9. It include the new unit tests (#3675) and the mentioned fix.

Hints for testers

Ensure that you can still whitelist websites successfully when using the experimental content blocking feature in the Safari extension. (This typo was unlikely to cause problems in practice, I can't think of a practical example of an incorrectly generated content blocking rule that is now fixed.)

Change History (5)

comment:1 Changed 3 years ago by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4076 - Update abp2blocklist dependency

comment:4 Changed 3 years ago by kzar

  • Cc Ross scheer added
  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Whitelisting works as expected when the experimental Safari content blocking is enabled.

ABP 1.12.0.1622
Safari 9 / OS X 10.11

Note: See TracTickets for help on using tickets.