Opened 3 years ago

Closed 2 years ago

Last modified 5 weeks ago

#4084 closed change (fixed)

Do not use @@bidi_dir directly in adblockplusui

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: #3697 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345232/

Description

Background

We have refactored the background page code in #3697. We should not use the @@bidi_dir directly now, and instead rely on Utils.readingDirection.

What to change

Replace calls of @@bidi_dir with Utils.readingDirection.

Change History (5)

comment:1 Changed 3 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by sebastian

  • Blocking 3697 added

comment:4 Changed 2 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 months ago by modifaku

spam

Last edited 5 weeks ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.