Opened 4 years ago

Closed 4 years ago

#4088 closed change (fixed)

JSHydra-generated module scopes shouldn't be called immediately

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345403/

Description (last modified by trev)

Background

JSHydra generates an anonymous function as the scope for each module. This anonymous function is currently called immediately.

What to change

In order to generate module scopes lazily when they are require'd for the first time, this anonymous function should no longer be called.

Integration notes

In order to integrate these changes, the implementation of require() has to be changed like in #4090. In addition, JSHydra rewriting parameters have to be adjusted in order to specify the modules to be loaded automatically (in #4090 this is done in manifest.common).

Change History (4)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by abpbot

comment:3 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
Issue 4088 - Update dependency on JSHydra to revision bb6fb9d5c9bc

comment:4 Changed 4 years ago by trev

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.