Opened 3 years ago

Closed 3 years ago

#4092 closed change (fixed)

Adapt unit tests for changes to InvalidFilter.reason

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345397/

Description

Background

InvalidFilter.reason changed to return a string ID rather than the actual error message.

What to change

Adapt unit tests to expect string IDs for this field.

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4092 - Adapt unit tests for changes to InvalidFilter.reason

comment:3 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.