Opened 3 years ago

Closed 2 years ago

#4096 closed defect (fixed)

qunit/index.html is being included in Chrome builds

Reported by: trev Assignee: tlucas
Priority: P4 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29503597/

Description

How to reproduce

  1. Unzip any development build from https://downloads.adblockplus.org/devbuilds/adblockpluschrome/, e.g. 1.11.0.1610.

Observed behaviour

There is a file qunit/index.html in the build, no other QUnit files are present.

Expected behaviour

The file qunit/index.html should not be part of the build, it should only be present in the development environment.

Change History (6)

comment:1 Changed 3 years ago by trev

  • Component changed from Unknown to Build-and-Release-Tools

comment:2 Changed 3 years ago by kzar

  • Keywords goodfirstbug added
  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed 2 years ago by tlucas

  • Owner set to tlucas

comment:4 Changed 2 years ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4096 - remove qunit/* from other builds than devenv

comment:6 Changed 2 years ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.