Opened 3 years ago

Closed 3 years ago

#4098 closed change (fixed)

Get rid of special build setup for development builds

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: sebastian Blocked By: #4097, #4099, #4108, #4109, #4110, #4111, #4112, #4113, #4114
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345508/

Description

Background

Development builds script currently assumes that all repositories are present locally. Also, it will always use the same copy of buildtools repository for all builds. While this is fast, it also creates consistency issues, particularly because of using the latest revision of buildtools repository. And we don't really want to keep maintaining local versions of all repositories on the build server.

What to change

Check out extension repository from https://hg.adblockplus.org/ rather than copying a local repository. Run ensure_dependencies.py without any special parameters to get all dependencies checked out as well. Add a an optional SpiderMonkey path to sitescripts.ini and pass it to the build via SPIDERMONKEY_BINARY environment variable (see #4097).

Change History (14)

comment:1 Changed 3 years ago by trev

  • Cc sebastian added

comment:2 Changed 3 years ago by trev

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 3 years ago by trev

  • Blocked By 4099 added

comment:4 Changed 3 years ago by trev

  • Review URL(s) modified (diff)

comment:5 Changed 3 years ago by trev

  • Blocked By 4108 added

comment:6 Changed 3 years ago by trev

  • Blocked By 4109 added

comment:7 Changed 3 years ago by trev

  • Blocked By 4110 added

comment:8 Changed 3 years ago by trev

  • Blocked By 4111 added

comment:9 Changed 3 years ago by trev

  • Blocked By 4112 added

comment:10 Changed 3 years ago by trev

  • Blocked By 4113 added

comment:11 Changed 3 years ago by trev

  • Blocked By 4114 added

comment:12 Changed 3 years ago by trev

  • Status changed from new to reviewing

comment:13 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4098 - Get rid of special build setup for development builds

comment:14 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Server configuration has been updated, it should generate new development builds in ~20 minutes.

Note: See TracTickets for help on using tickets.