Opened 3 years ago

Closed 3 years ago

#4099 closed change (fixed)

Don't enforce Gecko build IDs to be numerical

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #4098 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345505/

Description

Background

Right now, our command-line interface for development builds (as opposed to internal APIs) makes sure that build IDs passed in with the -b flag are numerical. This prevents Gecko development builds where we currently have build IDs like 1234-beta.

What to change

Drop requirement for build IDs to be numerical (at least for Gecko, other platforms aren't as flexible when it comes to version numbers).

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4099 - Don't enforce Gecko build IDs to be numerical

comment:3 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.