Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#41 closed defect (fixed)

Populate AppInfo.applicationVersion field properly

Reported by: trev Assignee: eric@…
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5171515343503360/

Description

Currently Adblock Plus for Internet Explorer only populates the AppInfo.application field but not AppInfo.applicationVersion. This field should be populated properly with the Internet Explorer version, otherwise we cannot distinguish version-specific issues properly.

Change History (9)

comment:1 Changed 5 years ago by eric@…

  • Ready unset

FYI. The current function that determines the IE version no longer retrieves the correct version with IE 10, because that version of IE has changed the way it records the version in the registry. See http://support.microsoft.com/kb/969393 for more information. The most relevant sentence: "The version string value for Internet Explorer 10 is 9.10.9200.16384, and the svcVersion string value is 10.0.9200.16384."

comment:2 Changed 5 years ago by eric@…

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by eric@…

  • Owner set to eric@…

comment:4 Changed 5 years ago by philll

  • Platform set to Internet Explorer

comment:5 Changed 5 years ago by oleksandr

  • Ready set

comment:6 Changed 5 years ago by sergz

Currently Adblock Plus for Internet Explorer only populates the AppInfo.application ...

The essential point here is that the speech is about AdblockPlusEngine. The engine should not be aware about the browser. The engine has no relationship with any browser, the client of the engine can be some UI-less service, or test client? If we really need some additional information here, it should come as a part of the first message of each client and should be client specific.

comment:7 Changed 5 years ago by trev

It can come as a command line parameter when the engine is started, like the browser locale. However, given that the engine is really a broker process for the various browser processes, I wouldn't get too religious about this.

comment:8 Changed 4 years ago by eric@…

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See TracTickets for help on using tickets.