Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#4118 closed defect (duplicate)

Yandex (biggest search engine in russia) ads still not blocked

Reported by: ethaniel Assignee:
Priority: P2 Milestone:
Module: Core Keywords:
Cc: greiner, mapx, Lain_13, fhd Blocked By: #2360
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

I have opened a ticket one year ago and you guys closed it saying that you are working on some "secret" feature that will block evasive ads like the ones that Yandex is using (see screenshot).

I think it was something with "hasText()" or similar.
What is the current status?

I am starting to believe that you have a secret agreement with Yandex instead where they pay you lots of money not to block them. Is that so?

Attachments (1)

yandex.png (182.0 KB) - added by ethaniel 3 years ago.

Download all attachments as: .zip

Change History (15)

Changed 3 years ago by ethaniel

comment:2 Changed 3 years ago by mapx

  • Cc greiner mapx Lain_13 added

comment:3 Changed 3 years ago by Lain_13

Also, it's worth to mention they are actively using lack of priority for user/extensions CSS in Google Chrome by adding style="display:block!important" to EVERYTHING.

I've a dirty patch for this: https://greasyfork.org/en/scripts/14720-it-s-not-important
Also, special for Yandex: https://greasyfork.org/en/scripts/809-no-yandex-ads

comment:4 Changed 3 years ago by fhd

  • Blocked By 2388 added
  • Component changed from Unknown to Core
  • Priority changed from Unknown to P2

I am starting to believe that you have a secret agreement with Yandex instead where they pay you lots of money not to block them. Is that so?

lol, no.

#2360 is the issue that should fix this, I'll look into that one.

Last edited 3 years ago by fhd (previous) (diff)

comment:5 Changed 3 years ago by fhd

  • Blocked By 2360 added; 2388 removed

comment:6 Changed 3 years ago by Lain_13

I wonder is there a way to use -abp-properties to detect blocks with extra data-something attributes?
Currently their ad blocks have extra attributes like data-secv or data-t535 and that part after "data-" is always different. As I understand CSS doesn't have wildcards for the attribute names and -abp-properties looks only for styles applied to the element (I haven't noticed any useful differences).

comment:7 follow-up: Changed 3 years ago by ethaniel

Here is my ticket from 1 year ago that you guys closed and made invisible: https://issues.adblockplus.org/ticket/2328#comment:1

No pressure, but I would love to see Yandex blocked within my lifetime.

comment:8 in reply to: ↑ 7 Changed 3 years ago by greiner

  • Cc fhd added
  • Resolution set to duplicate
  • Status changed from new to closed

Replying to Lain_13:

I wonder is there a way to use -abp-properties to detect blocks with extra data-something attributes?

-abp-properties targets CSS styles, not DOM attributes. So for that we'd need to implement yet another mechanism for element hiding.

Replying to ethaniel:

Here is my ticket from 1 year ago that you guys closed and made invisible: https://issues.adblockplus.org/ticket/2328#comment:1

Note that we closed that ticket because it's already covered by #2360 (specifically #3143). It'll likely require similar changes as in #2388.

Anyway, I hope you don't mind but I'm closing this ticket as duplicate since the issue should be taken care of in #3143.

comment:9 Changed 3 years ago by Lain_13

I think closing this ticket is wrong for two reasons:

  1. Mere implementation of :has() will only help to hide ads in search. It will help there for a moment, but then they will add display:block!important or something similar to everything and we will be back to square one. At least in Google Chrome. With only difference that my generic script "it's not important" will help there.
  2. It serves as a tracking ticket. They also have ads in news which is possible to hide with -abp-properties, but only in Firefox (due to issue mentioned above).

So, I'd recommend to reopen it as a meta bug and mark as blocked by #2398 (Yandex.News in Firefox), #3143 (ads in search), that one bug about display:block!important (Yandex.News in Chrome, I wasn't able to find it) and, probably, #756 (may help with a previous issue for some time and with a lot of non-collapsible empty blocks on other sites).

We already have a lot of issues with Yandex and they will only make more for us in the future. So, it's a good idea to show why exactly we can't block their ads.

Version 1, edited 3 years ago by Lain_13 (previous) (next) (diff)

comment:10 Changed 3 years ago by greiner

We have meta tickets for keeping track of issues that require multiple changes but for separate issues we should still have separate tickets so that we can tackle them independently from each other.

Feel free to refer back to this ticket in case other issues come up that are related to Yandex search. It being closed merely means that there's nothing actionable that we could work on but it can still be used to provide context for other tickets.

comment:11 follow-up: Changed 3 years ago by fhd

FWIW, I actually deliberately kept it open because this is a BUG (that we may well have to reopen!), whereas #2360 is just one issue that tries to resolve it.

comment:12 in reply to: ↑ 11 Changed 3 years ago by greiner

Replying to fhd:

FWIW, I actually deliberately kept it open because this is a BUG (that we may well have to reopen!), whereas #2360 is just one issue that tries to resolve it.

Ok, in that case feel free to reopen and keep it in sync with #2360.

comment:13 Changed 3 years ago by ethaniel

Here is how uBlock Origin solved this problem:

yandex.ru##.serp-item:has(:scope > .organic > .organic__subtitle > .label_color_yellow)

We need to adopt has() asap.

Last edited 3 years ago by ethaniel (previous) (diff)

comment:14 Changed 2 years ago by bopoh13

Men, they constantly change something. My recommendation on today.

Note: See TracTickets for help on using tickets.