Opened 4 years ago

Last modified 2 months ago

#4128 closed change

[emscripten] Convert parsing/serializing patterns.ini to C++ — at Initial Version

Reported by: trev Assignee:
Priority: P2 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29548581/

Description

Background

See #4122 for the rationale. While converting all of FilterStorage functionality to C++ isn't necessary, parsing/serializing patterns.ini definitely needs to happen in C++.

What to change

Create INIParser() and INISerializer() classes in C++. INIParser() should have methods parse() (parsing next chunk), finalize() (parse last chunk and replace existing filters/subscriptions) and delete() (release reference). No changes to existing data structures should be performed before finalize() is called.

INISerializer() should have the method getChunk() returning the next chunk of data to be written to disk and delete() (release reference).

Change History (0)

Note: See TracTickets for help on using tickets.