Opened 3 years ago

Closed 3 years ago

Last modified 7 weeks ago

#4129 closed change (fixed)

Reuse EventEmitter class in messaging module

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345627/

Description

Background

Core has an events module providing EventEmitter class now, the API is very similar to the Port class in messaging module.

What to change

Encapsulate an event emitter for the Port class and delegate managing of event listeners to it.

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4129 - Reuse EventEmitter class in messaging module

comment:3 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.