Opened 4 years ago

Closed 3 years ago

Last modified 2 months ago

#4130 closed change (fixed)

Turn off HockeyApp upgrade notifications in debug builds

Reported by: mario Assignee:
Priority: P3 Milestone: Adblock-Browser-for-iOS-1.5.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: pavelz Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by mario)

Background

The HockeyApp integration raises upgrade notifications when new development builds are available.
These upgrade notifications hinder rapid debugging as after every restart the notification needs to be dismissed. Thus we want to disable these notifications in debug builds.

What to change

Disable HockeyApp upgrade notifications in debug builds.

Remark for testers

Please validate that upgrade notifications are still raised in development builds.

Change History (17)

comment:2 Changed 3 years ago by mario

  • Ready unset

comment:3 Changed 3 years ago by mario

  • Description modified (diff)
  • Ready set

comment:4 Changed 3 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 3 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next
  • Summary changed from Turn off HockeyApp upgrade notifications to Turn off HockeyApp upgrade notifications in debug builds

comment:6 Changed 3 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer

Currently, you are not shown an upgrade notification when a newer version is available in Development builds.

This was attempted with 1.4.0 (1046) > 1.5.0 (1060).

iPhone 6s Plus
iOS 9.3.1

comment:7 Changed 3 years ago by pavelz

  • Resolution set to fixed
  • Status changed from reopened to closed

The feature must be tested on version 1.5.0, as it was implemented in 1.5.0. So the version "from" cannot be 1.4.0. Furthermore, the version "to" must be UNRESTRICTED PUBLIC. ABB does not ask for any Hockeyapp credentials, so there is no other way for the app to find out that there is a newer version available. No 1.5.0-qa build was made so public yet by Eyeo.

comment:8 Changed 3 years ago by scheer

  • Verified working set
  • The upgrade notification no longer appears in non-public development builds.

ABB iOS 1.5.0 (1077 > 1110)
iPhone 6s Plus
iOS 9.3.1

comment:9 Changed 9 months ago by takken3

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:10 Changed 7 months ago by jennifergrace

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:11 Changed 7 months ago by Angus O'Driscoll

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:12 Changed 6 months ago by writingmetier

Did they validate those upgrade notifications or they still appear? Will be interested for https://writingmetier.com to know it.
Keep in touch!

Version 0, edited 6 months ago by writingmetier (next)

comment:13 Changed 2 months ago by graceedens

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:14 Changed 2 months ago by graceedens

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:15 Changed 2 months ago by graceedens

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:16 Changed 2 months ago by graceedens

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:17 Changed 2 months ago by graceedens

spam

Last edited 2 months ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.