Opened 3 years ago

Closed 3 years ago

Last modified 5 weeks ago

#4131 closed change (fixed)

Simplify UI initialization logic

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345630/

Description

Background

The UI initialization logic is currently rather complicated, it has to wait for three different events to happen.

What to change

Use promises to join the three events required for UI initialization. Also, use new FilterNotifier API.

Change History (5)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 months ago by Archie Radcliffe

You are quite right, it is very easy to modify the syntax error in the program but the problem with the logical error of the program. https://www.lilachbullock.com/online-marketing-techniques-for-higher-education/ You are right that we should check the program meticulously before compiling it.

comment:4 Changed 4 months ago by Ora Kessler

I do agree with you that UI logic is complicated yet for non-technical peopole like me and require to read essayshark review or your article for simplify it. Well your struggles for simplifying the logic is appreciative.

comment:5 Changed 5 weeks ago by johnsullen

If you have plucked up your courage and made up your mind to rewrite an essay from scratch, it is important for you to be more attentive and considerate. You may need some additional tips towards rewriting essays https://primeessays.com/rewriting-an-essay-tips.html

Note: See TracTickets for help on using tickets.