Opened 4 years ago

Closed 4 years ago

Last modified 9 months ago

#4131 closed change (fixed)

Simplify UI initialization logic

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29345630/

Description

Background

The UI initialization logic is currently rather complicated, it has to wait for three different events to happen.

What to change

Use promises to join the three events required for UI initialization. Also, use new FilterNotifier API.

Change History (5)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/7cf793d35ab7

comment:3 Changed 14 months ago by Archie Radcliffe

You are quite right, it is very easy to modify the syntax error in the program but the problem with the logical error of the program. ​https://www.lilachbullock.com/online-marketing-techniques-for-higher-education/ You are right that we should check the program meticulously before compiling it.

Version 0, edited 14 months ago by Archie Radcliffe (next)

comment:4 Changed 14 months ago by Ora Kessler

spam

Last edited 9 months ago by kzar (previous) (diff)

comment:5 Changed 11 months ago by johnsullen

spam

Last edited 9 months ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.