Opened 3 years ago

Closed 3 years ago

Last modified 2 months ago

#4131 closed change (fixed)

Simplify UI initialization logic

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345630/

Description

Background

The UI initialization logic is currently rather complicated, it has to wait for three different events to happen.

What to change

Use promises to join the three events required for UI initialization. Also, use new FilterNotifier API.

Change History (5)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 7 months ago by Archie Radcliffe

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:4 Changed 7 months ago by Ora Kessler

I do agree with you that UI logic is complicated yet for non-technical peopole like me and require to read essayshark review or your article for simplify it. Well your struggles for simplifying the logic is appreciative.

Version 0, edited 7 months ago by Ora Kessler (next)

comment:5 Changed 4 months ago by johnsullen

spam

Last edited 2 months ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.