Opened 3 years ago

Closed 3 years ago

#4133 closed change (fixed)

Switch to new FilterNotifier API in UI module

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345633/

Description

Background

FilterNotifier.addListener() is deprecated. In addition to the occurrence replaced in #4131 there is another spot in the UI module calling that method.

What to change

Replace FilterNotifier.addListener() call by multiple FilterNotifier.on() calls.

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4133 - Switch to new FilterNotifier API in UI module

comment:3 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.