Changes between Version 4 and Version 5 of Ticket #4136


Ignore:
Timestamp:
07/25/2016 04:17:04 PM (3 years ago)
Author:
greiner
Comment:

According to Chromium Issue 608869 they added chrome.devtools.panels.themeName a few weeks ago so we should be able to use it as soon as it lands in Chrome's dev channel.

Note that we can't use the body's -theme-with-dark-background class because our panel is running inside of an iFrame.

At the moment the only thing we could do is set html {background-color: #FFF;} to ensure that our content remains usable.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4136

    • Property Priority changed from Unknown to P3
    • Property Keywords externaldependency added
  • Ticket #4136 – Description

    v4 v5  
    1717 
    1818=== Notes === 
    19 - The inspector itself can be inspected using the Ctrl-Shift-I (Ctrl-Apple-I for Macs) [https://developers.google.com/web/tools/chrome-devtools/iterate/inspect-styles/shortcuts#global-keyboard-shortcuts hotkey] as long as the inspector is undocked from the page. 
    20 - When the dark theme is enabled the body element has an extra class `-theme-with-dark-background`. 
     19The inspector itself can be inspected using the Ctrl-Shift-I (Ctrl-Apple-I for Macs) [https://developers.google.com/web/tools/chrome-devtools/iterate/inspect-styles/shortcuts#global-keyboard-shortcuts hotkey] as long as the inspector is undocked from the page. 
     20 
     21=== What to change === 
     22Use `chrome.devtools.panels.themeName` (see [https://bugs.chromium.org/p/chromium/issues/detail?id=608869 Chromium Issue 608869]) to apply additional styles in case of themes being applied. Note that while we can make specific optimizations to the "dark" theme we may need to have some generic fallback style for any other ones that may be added to avoid future breakage.