Opened 17 months ago

Closed 17 months ago

Last modified 16 months ago

#4141 closed defect (fixed)

Video ads on YouTube not blocked

Reported by: arthur Assignee: trev
Priority: P1 Milestone: Adblock-Plus-1.12.1-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: kzar, sebastian, TobiasHilleke, trev Blocked By:
Blocking: #3687 Platform: Safari
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29345734/

Description (last modified by trev)

Environment

  • Safari 7.1.8
  • OSX 10.9.5
  • ABP 1.12
  • EasyList and Acceptable Ads

Also reproducible on newer Safari versions after running the following from the command line:

defaults write com.apple.Safari CustomUserAgent "\"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9) AppleWebKit/537.71 (KHTML, like Gecko) Version/7.0 Safari/537.71\""

Right-click the video on YouTube to verify that you see the Flash video player and not the HTML5 one. This change can be undone using the following command:

defaults delete com.apple.Safari CustomUserAgent

How to reproduce

  1. Open https://www.youtube.com/watch?v=0HGenoCF8Js or https://www.youtube.com/watch?v=guHKf6GxqTw&feature=youtu.be
  2. (might need to test with other videos from the sidebar)

Observed behaviour

Video ad appearing before the video (served via Flash).

Expected behaviour

Video ads should be blocked.

Change History (10)

comment:1 Changed 17 months ago by mapx

  • Cc kzar sebastian added

comment:2 Changed 17 months ago by arthur

  • Cc TobiasHilleke added
  • Description modified (diff)

comment:3 Changed 17 months ago by sebastian

  • Cc trev added

comment:4 Changed 17 months ago by trev

  • Component changed from Unknown to Platform
  • Priority changed from Unknown to P1
  • Ready set

I can confirm this issue in Safari 9.1.1. However, the important keyword here is "flash" - it doesn't affect the HTML5 player, only the legacy Flash player. In order to get the Flash player I had to change Safari's user agent:

defaults write com.apple.Safari CustomUserAgent "\"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9) AppleWebKit/537.71 (KHTML, like Gecko) Version/7.0 Safari/537.71\""

This will cause YouTube to show the Flash video player and it will play an advertisement for these videos. Adblock Plus 1.11 is fine, only Adblock Plus 1.12 shows this behavior.

comment:5 Changed 17 months ago by trev

  • Blocking 3687 added
  • Owner set to trev

This is fallout from #3687.

comment:6 Changed 17 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 17 months ago by trev

  • Description modified (diff)

comment:8 Changed 17 months ago by abpbot

A commit referencing this issue has landed:
Issue 4141 - Safari: Fixed blocking of video ads on YouTube

comment:9 Changed 17 months ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 16 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Adverts no longer play before the video when the Flash player is used in Safari.

ABP 1.12.0.1622
Safari 7 / OS X 10.9

Note: See TracTickets for help on using tickets.