Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4143 closed change (fixed)

Switch content of our ABB HockeyApp channels

Reported by: mario Assignee:
Priority: P2 Milestone:
Module: Adblock-Browser-for-iOS Keywords:
Cc: pavelz Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mario)

Background

As per #3906 we have introduced an additional App-ID for Adblock Browser which will only be used for development builds. Thereby we're logically separating release builds from development builds:

  • ABB release builds are built and signed using the App-ID org.adblockplus.adblockbrowser
  • ABB development builds are built and signed using the App-ID org.adblockplus.devbuilds.adblockbrowser

Following this separation, we have split our former HockeyApp channel into two:

The former channel was planned to be used for signed App Store builds only in order to gather crash reports. The latter was planned to be used for external testing as well as for devbuild users to obtain development builds.

However, the channel, which is currently intended to be our release channel, was our former main distribution channel. Thus this channel already holds a long history of remaining devbuilds and on top of that is already known by third parties as our "devbuild channel". If we kept this as our release channel, we'd "lose" the devbuild history and we'd need to communicate a new channel to all devbuild users as well as testers.
In order to keep said devbuild history and not to confuse devbuild users, we would like to switch the content of both channels.

What to change

For the HA channel with channel id 310687

  • Rename the channel to "Adblock Browser Release"
  • Remove all existing development builds
  • Copy all release builds from 185237 to this channel
  • Make this channel private*
  • Change the owner of the channel to the same as 185237

For the HA channel with channel id 185237

  • Rename the channel to "Adblock Browser Devbuilds"
  • Make all existing release builds private*
  • Mark all existing release builds "not downloadable"
  • Upload the most recent ABB 1.4.0 devbuild to this channel
  • Keep all existing development/qa builds
  • Make this channel public*
  • Make all existing devbuilds public*

*public = Accessible by anyone, with or without an HA account
*private = Only accessible by HA users in the groups "Eyeo" and "Salsita"

Change History (12)

comment:1 Changed 3 years ago by mario

  • Description modified (diff)

comment:2 Changed 3 years ago by mario

  • Description modified (diff)

comment:3 Changed 3 years ago by pavelz

  • Description modified (diff)

Moving app builds between channels it tedious. There is no in-service method to do it. Which the service authors can't be slandered for, as a moved app will have all the above disadvantages introduced. So the only way is to download the app to local drive and upload again manually to the new channel.

There is no point in moving any devbuilds. Potential crash reports will keep landing in 310687, and release notes will have to be written again anyway (it's just the IPA being moved). When the build service configuration is flipped, it would be way more useful to just spin a new devbuild and have it landed in the correct place, with correct crash report addressing. Old devbuilds can be deleted. It really has no usage scenario left.

Moving the former releases is reasonable, even though the crash reports attachment will be lost too - it will keep appearing in the other channel.

comment:4 follow-up: Changed 3 years ago by mario

  • Cc pavelz added
  • Description modified (diff)

Moving app builds between channels it tedious. There is no in-service method to do it. Which the service authors can't be slandered for, as a moved app will have all the above disadvantages introduced. So the only way is to download the app to local drive and upload again manually to the new channel.

I'd be fine with providing the latest build of 1.4.0 at 185237.

There is no point in moving any devbuilds. Potential crash reports will keep landing in 310687, and release notes will have to be written again anyway (it's just the IPA being moved). When the build service configuration is flipped, it would be way more useful to just spin a new devbuild and have it landed in the correct place, with correct crash report addressing. Old devbuilds can be deleted. It really has no usage scenario left.

Aside from the current 1.4.0 we don't need to move any other devbuilds, do we?
But as I said, I'd be perfectly fine with removing them from 310687 and uploading the most recent to 185237.

Moving the former releases is reasonable, even though the crash reports attachment will be lost too - it will keep appearing in the other channel.

Losing the crash reports would be not good. In my opinion it's crucial to keep them in case we need to look them up at some point. The only option we have in this case would be to make them private but keep them in 185237, right?

comment:5 Changed 3 years ago by mario

  • Description modified (diff)

comment:6 in reply to: ↑ 4 Changed 3 years ago by pavelz

  • Description modified (diff)

Replying to mario:

Aside from the current 1.4.0 we don't need to move any other devbuilds, do we?
But as I said, I'd be perfectly fine with removing them from 310687 and uploading the most recent to 185237.

If you want "just the last one", then the moving makes even less sense. If anyone ever uses that build, and crashes it, the report will land in 310687 not 185237. So why not change the build service config, spin a new devbuild, and have just that one as a start in 185237? The release notes would have to be copy&pasted manually anyway, to such new builds as well as a copied former build.

Moving the former releases is reasonable, even though the crash reports attachment will be lost too - it will keep appearing in the other channel.

Losing the crash reports would be not good. In my opinion it's crucial to keep them in case we need to look them up at some point. The only option we have in this case would be to make them private but keep them in 185237, right?

Right. So the strategy is to *copy* not move, the former release builds, and make the originals private. In that sense, it won't be "ghost" but a full app, potentially installable, but it's the only way to keep the crash reports.

comment:7 Changed 3 years ago by mario

  • Description modified (diff)
  • Ready set

If you want "just the last one", then the moving makes even less sense. If anyone ever uses that build, and crashes it, the report will land in 310687 not 185237. So why not change the build service config, spin a new devbuild, and have just that one as a start in 185237? The release notes would have to be copy&pasted manually anyway, to such new builds as well as a copied former build.

That's exactly what I meant with my previous comment. I'll change the issue accordingly.

Right. So the strategy is to *copy* not move, the former release builds, and make the originals private. In that sense, it won't be "ghost" but a full app, potentially installable, but it's the only way to keep the crash reports.

Agreed. We can also mark them to be "not dowbloadable". I'll change the issue to reflect that.

comment:8 Changed 3 years ago by pavelz

Also wrap under this ticket: the new channel 310687 is still owned by Salsita, because i have created it. It must be transferred to Eyeo. I need to know an email of HA account which is eligible as transfer target. The account must be Owner of some existing channel. The owner of former 185237 is adblockbrowser@… under name Wladimir Palant. If this email is not usable for transferring another channel (you can't reach the email or is used for other purposes), channel 185237 must be configured to have yet another Owner with a different email. Then ping me and i will transfer 310687 to the email.

comment:9 Changed 3 years ago by mario

  • Description modified (diff)

Also wrap under this ticket: the new channel 310687 is still owned by Salsita, because i have created it. It must be transferred to Eyeo. I need to know an email of HA account which is eligible as transfer target. The account must be Owner of some existing channel. The owner of former 185237 is adblockbrowser@… under name Wladimir Palant. If this email is not usable for transferring another channel (you can't reach the email or is used for other purposes), channel 185237 must be configured to have yet another Owner with a different email. Then ping me and i will transfer 310687 to the email.

The same as for 185237. Added to the issue.

comment:11 Changed 3 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

comment:12 Changed 3 years ago by pavelz

Note: See TracTickets for help on using tickets.