Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4147 closed change (fixed)

Add a high-res version of the 32x32 ABP icon

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: christiane Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29357377/

Description (last modified by trev)

Background

While #4142 added a high-res version of the 16x16 toolbar icon, the larger icon (displayed for example if ABP is placed inside the "hamburger menu") remains unchanged. It could look better on high-res displays.

What to change

On screens with higher pixel density use attached abp-status-48.png and abp-status-64.png instead of abp-status-32.png.

Attachments (2)

abp-status-48.png (1.8 KB) - added by trev 3 years ago.
48x96 variant
abp-status-64.png (2.6 KB) - added by trev 3 years ago.
64x128 variant

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by trev

48x96 variant

Changed 3 years ago by trev

64x128 variant

comment:1 Changed 3 years ago by trev

  • Description modified (diff)
  • Owner set to trev
  • Ready set

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4147 - Add a high-res version of the 32x32 ABP icon

comment:4 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by trev

  • Milestone changed from Adblock-Plus-for-Chrome-Opera-Safari-next to Adblock-Plus-for-Firefox-next

comment:6 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. New icon appears to be used, looks fine in both states and in multiple locations (toolbar, hamburger menu). Tested on 2800 x 1620 resolution.

2.7.3-4214-beta
Firefox 39 / 49 / Windows 7
Firefox 45 / Nightly / Ubuntu 14.04

Note: See TracTickets for help on using tickets.