Opened 3 years ago

Closed 3 years ago

#4162 closed change (fixed)

Rename about:abp-elemhidehit into about:abp-elemhide

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #4139
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29346609/

Description

Background

Now that our about: page is used for more than just hit testing (see #4139), the name about:abp-elemhidehit no longer fits.

What to change

Rename the page into about:abp-elemhide, the hit URLs should become about:abp-elemhide?hit12345 and the stylesheet URL about:abp-elemhidehit?css.

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4162 - Rename about:abp-elemhidehit into about:abp-elemhide

comment:3 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.