Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4166 closed defect (fixed)

ABB crashes when having to many active filters lists

Reported by: scheer Assignee:
Priority: P1 Milestone: Adblock-Browser-for-iOS-1.4.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description

When the user activates too many (c.a 10) filter lists, ABB crashes and then crashes each time the user attempts to re-launch the app.

The same behaviour can be invoked when the user has the normal English easylist installed and adds 1 additional easylist language, so that there are never more than two lists active at any time. Then, replaces the newly added list with another language. After repeating this step the 7th or 8th list added creates the same crash.

Environment

ABB 1.4.0-qa (1038)
iPhone 6 Plus
iOS 9.3.1
AA Enabled
All 'More blocking options' are disabled
URL search suggestions are Off

How to reproduce

  1. Add as many filter lists as you can

OR

  1. Have the default English Easylist active
  2. Add the first available filter list
  3. Wait three to four seconds
  4. Disable the filter list added in step 2
  5. Add the next available filter list
  6. Continue to repeat steps 2-5

Observed behaviour

ABB crashes and upon trying to relaunch the app, it either instantly crashes again or loads to the Bookmarks screen and then crashes again.

Expected behaviour

Adding filter lists should not crash ABB.

Attachments (1)

FILTER LIST JETSAM CRASH.txt (19.1 KB) - added by scheer 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by scheer

comment:1 Changed 3 years ago by scheer

  • Milestone set to Adblock-Browser-for-iOS-1.4.0

comment:2 Changed 3 years ago by mario

  • Ready set

comment:3 Changed 3 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in 1.4.0 qa build 1043 by merging chrome.storage fix from develop listed in https://issues.adblockplus.org/ticket/4012

comment:4 Changed 3 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set

I am no longer able to crash ABB with the steps provided above.

ABB 1.4.0 (1043)
iPhone 6 Plus
iOS 9.3.1

comment:5 Changed 3 years ago by mario

  • Priority changed from Unknown to P1
Note: See TracTickets for help on using tickets.