Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4167 closed change (fixed)

Update ElemHide APIs to allow Firefox to be switched to per-site stylesheets

Reported by: trev Assignee: kzar
Priority: P4 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #524, #4477 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29349187/

Description

Background

In #524 we want to split up the current singular stylesheet into per-domain rules and rules that are always applied. ElemHide APIs need to be adjusted for that.

What to change

  • Remove usingGetSelectorsForDomain flag - all implementations will need ElemHide.getSelectorsForDomain() API now.
  • Replace ElemHide.getSelectors() by Elemhide.getUnconditionalSelectors() which should essentially return the value of unconditionalSelectors variable.
  • Add an additional parameter noUnconditional to ElemHide.getSelectorsForDomain() - unconditionalSelectors should only be considered if that flag isn't set.

Change History (6)

comment:1 Changed 3 years ago by kzar

  • Cc kzar added
  • Review URL(s) modified (diff)

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4167 - getSelectorsForDomain criteria + keys

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4167 - Fixed getUnconditionalFilterKeys comment

comment:4 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 3 years ago by kzar

  • Cc kzar removed
  • Owner set to kzar

comment:6 Changed 3 years ago by kzar

  • Blocking 4477 added
Note: See TracTickets for help on using tickets.