Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4168 closed defect (invalid)

Editing a filter in Element Hiding Helper

Reported by: cmmc Assignee:
Priority: Unknown Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev, greiner, mapx Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Windows 7 sp1 x64
Firefox nightly 50.0a1
ABP 2.7.3
EHH 1.3.8
Fanboy Easylist ultimate (not influencial in this bug)

How to reproduce

  1. Go to http://www.zerohedge.com/news/2016-06-17/sanders-supporters-vindicated-proof-dnc-used-media-rig-election-hillary (or any other article on the site).
  2. Select an element to hide (eg: zerohedge.com###ad-sidebarleft-top).
  3. Replace the filtered element by another one up the element tree (eg: zerohedge.com###ad-header).

Observed behaviour

You'll end up with this filter: zerohedge.com###ad-header + * + * + * > * and the whole page gets filtered out, except for some headers.
Editing the filter to remove the + * + * + * > * part fixes the problem.

Expected behaviour

Element ad-header is added to the filter and element ad-sidebarleft-top is removed from it, without any other extra code left appended.

This was also reported here: https://adblockplus.org/forum/viewtopic.php?f=1&t=45788

Change History (2)

comment:1 Changed 3 years ago by mapx

  • Cc trev greiner mapx added
  • Component changed from Unknown to Extensions-for-Adblock-Plus

comment:2 Changed 3 years ago by trev

  • Resolution set to invalid
  • Status changed from new to closed

This is a misunderstanding of how Element Hiding Helper works. By the time the filter assistant opens the element is already selected, it can no longer be changed. If you select a parent element in the filter assistant then you are saying that you want to hide this element based on its parent element. If instead you mean to hide the parent element you should use the "w" key ("wider") when selecting.

Last edited 3 years ago by trev (previous) (diff)
Note: See TracTickets for help on using tickets.