Opened 6 years ago

Closed 6 years ago

#417 closed change (fixed)

Re-initializing removed filterlists in Chrome

Reported by: jobp Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-1.8.3-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: greiner, smultron45@… Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5450822905233408/
http://codereview.adblockplus.org/6468765319430144/

Description (last modified by greiner)

Background

The removal of the filterlists in Chrome over the last months, is still leaving a significant part of the ABP for Chrome userbase without any filterlists. These users are exposed to ads, while having ABP enabled.

What to change

To protect those users exposed to annoying ads due to this issue, we should reinitialize the filterlists for them. The implementation looks like this:

  • On startup check whether patterns.ini is empty (size is zero)
  • If that is the case execute the first-run actions
  • Show the first-run page containing a message to inform the user about the issue and the actions we took

Change History (12)

comment:1 Changed 6 years ago by mapx

  • Cc smultron45@… added

comment:2 Changed 6 years ago by jobp

Never mind, heard from @fhd that this is already taken care of.

comment:3 Changed 6 years ago by fhd

  • Priority changed from Unknown to P2

This should have been fixed by #361, but apparently it's not :(

Thomas, can you shed some light on this?

comment:4 Changed 6 years ago by greiner

Sure, #361 fixes the issue of filterlists being removed while this issue is about detecting that it happened and resetting the extension's settings in those cases. This was not included in #361 due to lack of consent on whether/how this should be done and communicated to the user.

comment:5 Changed 6 years ago by philll

As far as I can remember, our latest agreement was on a notification in case of no filter active, asking the user, whether we should reset the application defaults with a filter list matching his language.

comment:6 Changed 6 years ago by greiner

After discussing this in the intraforum and on IRC we agreed on the following implementation:

  • On startup check whether patterns.ini is empty (size is zero)
  • If that is the case execute the first-run actions
  • Show the first-run page containing a message to inform the user about the issue and the actions we took

comment:7 Changed 6 years ago by greiner

  • Owner set to greiner
  • Ready set

comment:8 Changed 6 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 6 years ago by philll

@greiner: please ensure the actually implemented feature set to be written down in the what to change section.

comment:10 Changed 6 years ago by philll

  • Ready unset

comment:11 Changed 6 years ago by greiner

  • Description modified (diff)
  • Ready set

comment:12 Changed 6 years ago by greiner

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.