Opened 3 years ago

Closed 2 years ago

#4188 closed change (fixed)

Update libadblockplus-android to use the latest libadblockplus

Reported by: asmirnov Assignee: asmirnov
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: rjeschke, sergz Blocked By: #4194
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29347012/

Description (last modified by asmirnov)

Currently libadblockplus-android (https://hg.adblockplus.org/libadblockplus-android/rev/23e85c987663) uses libadblockplus-binaries revision aafebe7adfee1691d6dd8656f8c8628fa5ee1209 built for not the latest libadblockplus revision.

dependencies file:

libadblockplus-android/jni/libadblockplus-binaries = libadblockplus-binaries hg:aafebe7adfee1691d6dd8656f8c8628fa5ee1209 git:84620d7a1c7bc71d3af864384478160a864de698

Here is the list of latest changes imported:
#3594, #4612 and all the libadblockplus issues created after Dec 5, 2015 (lots of)

aafebe7adfee1691d6dd8656f8c8628fa5ee1209 binaries relate to libadblockplus revision aea52ce09b97 which is 6-months-old.

libadblockplus-android should be changed to be compiled again the latest libadblockplus revision 031f392dda1. or even newer if created.

modify 'libadblockplus-binaries' and 'libadblockplus-android' repositories (to be synced)

Change History (11)

comment:1 Changed 3 years ago by asmirnov

  • Description modified (diff)

comment:2 Changed 3 years ago by asmirnov

  • Description modified (diff)

comment:3 Changed 3 years ago by asmirnov

  • Owner set to asmirnov

comment:4 Changed 3 years ago by asmirnov

  • Blocked By 4194 added

comment:5 Changed 3 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 follow-up: Changed 3 years ago by fhd

Could you list any libadblockplus issues that have landed in the mean time and think about whether we need to change libadblockplus-android for that? Here's an example of a dependency update issue: #2732.

comment:7 Changed 3 years ago by asmirnov

  • Description modified (diff)

comment:8 in reply to: ↑ 6 Changed 3 years ago by asmirnov

Replying to fhd:

Could you list any libadblockplus issues that have landed in the mean time and think about whether we need to change libadblockplus-android for that? Here's an example of a dependency update issue: #2732.

Updated issue description.
It seems that #4612 is enough to update libadblockplus-android at least.

comment:9 Changed 3 years ago by abpbot

comment:10 Changed 3 years ago by abpbot

comment:11 Changed 2 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

It seems not relevant already

Note: See TracTickets for help on using tickets.