Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4199 closed defect (fixed)

Enabling Safari content blocking causes ABP to lose track of options tab

Reported by: Ross Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.12.2-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29347042/

Description (last modified by kzar)

Environment

ABP 1.12
Safari 9 / OS X 10.11

How to reproduce

  1. Install ABP 1.12 and enable Safari Content Blocking.
  2. Select [ABP Icon] > [Options]. Options page appears in a new tab.
  3. Navigate to a website in the options page tab (I used http://www.arstechnica.com).
  4. Select [ABP Icon] > [Options].

Observed behaviour

Nothing happens when the [Options] button is pushed. You have to close the tab opened in step 2 for the button to work.

Expected behaviour

The [Options] button should continue to work.

Notes

This behaviour is present in 1.12 and more recent code, but only when the Safari Content Blocking feature is enabled.

Change History (5)

comment:1 Changed 3 years ago by kzar

  • Cc sebastian added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Owner set to kzar
  • Priority changed from Unknown to P2
  • Ready set

Can reproduce as described with 1.12 and the latest code scheduled for the 1.12.1 release. Like you say it seems to only happen when using the experimental content blocking feature.

As this bug exists in the existing version and is relatively minor I think we should go ahead with the 1.12.1 release tomorrow anyway. Ultimately though that's up to Sebastian.

Either way I'm investigating to understand what's causing this bug now.

comment:2 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4199 - Track Safari tabs properly in Content Blocking mode

comment:4 Changed 3 years ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • When selecting [ABP Icon] > [Options] after loading a new page in the already opened options page, the new options page loaded correctly.

ABP 1.12.1.1644
Safari 9 / OS X 10.11

Note: See TracTickets for help on using tickets.