Opened 3 years ago

Closed 3 years ago

#4201 closed defect (fixed)

CSS property filter still applied when ABP is disabled everywhere

Reported by: arthur Assignee: trev
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: trev, mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29347939/

Description

Environment

Windows 10 Pro
Firefox 47
ABP 2.7.3.4184

How to reproduce

  1. Add this custom filter: testpages.adblockplus.org##[-abp-properties='width: 64px;']
  2. Go to ​https://testpages.adblockplus.org/
  3. Notice the ABP logo is being hidden by this filter
  4. Disable ABP everywhere via the context menu
  5. Refresh the page

Observed behaviour

The custom filter is still being applied.

Expected behaviour

ABP shouldn't apply any filters when it's disabled.

It's working fine if you disable ABP for this particular domain only.

Change History (7)

comment:1 Changed 3 years ago by mapx

  • Cc mapx added

comment:2 Changed 3 years ago by trev

  • Priority changed from Unknown to P1
  • Ready set

comment:3 Changed 3 years ago by trev

  • Component changed from Adblock-Plus-for-Firefox to Core
  • Owner set to trev

comment:4 Changed 3 years ago by trev

  • Component changed from Core to User-Interface

Actually, the problematic code is in the adblockplusui repository (messageResponder.js) so technically this is UI...

comment:5 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

I filed #4250 for the dependency update.

Note: See TracTickets for help on using tickets.