Opened on 06/28/2016 at 10:35:13 AM

Closed on 07/18/2016 at 06:13:19 PM

#4201 closed defect (fixed)

CSS property filter still applied when ABP is disabled everywhere

Reported by: arthur Assignee: trev
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: trev, mapx Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Windows 10 Pro
Firefox 47

How to reproduce

  1. Add this custom filter:[-abp-properties='width: 64px;']
  2. Go to
  3. Notice the ABP logo is being hidden by this filter
  4. Disable ABP everywhere via the context menu
  5. Refresh the page

Observed behaviour

The custom filter is still being applied.

Expected behaviour

ABP shouldn't apply any filters when it's disabled.

It's working fine if you disable ABP for this particular domain only.

Attachments (0)

Change History (7)

comment:1 Changed on 06/28/2016 at 04:37:20 PM by mapx

  • Cc mapx added

comment:2 Changed on 07/18/2016 at 03:48:22 PM by trev

  • Priority changed from Unknown to P1
  • Ready set

comment:3 Changed on 07/18/2016 at 03:50:01 PM by trev

  • Component changed from Adblock-Plus-for-Firefox to Core
  • Owner set to trev

comment:4 Changed on 07/18/2016 at 03:50:54 PM by trev

  • Component changed from Core to User-Interface

Actually, the problematic code is in the adblockplusui repository (messageResponder.js) so technically this is UI...

comment:5 Changed on 07/18/2016 at 03:53:45 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 07/18/2016 at 06:09:45 PM by abpbot

comment:7 Changed on 07/18/2016 at 06:13:19 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

I filed #4250 for the dependency update.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.