Opened 2 years ago

Closed 4 weeks ago

#4202 closed defect (fixed)

Fix failing AndroidWebRequestTest.testXMLHttpRequest

Reported by: asmirnov Assignee: asmirnov
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29347164/

Description

Current it's failing due to the following error:

[exec] org.adblockplus.libadblockplus.tests.AndroidWebRequestTest:..
     [exec] Error in testXMLHttpRequest:
     [exec] org.adblockplus.libadblockplus.AdblockPlusException: ReferenceError: XMLHttpRequest is not defined at undefined:2
     [exec] 	at org.adblockplus.libadblockplus.JsEngine.evaluate(Native Method)
     [exec] 	at org.adblockplus.libadblockplus.JsEngine.evaluate(JsEngine.java:61)
     [exec] 	at org.adblockplus.libadblockplus.tests.AndroidWebRequestTest.testXMLHttpRequest(AndroidWebRequestTest.java:78)
     [exec] 	at java.lang.reflect.Method.invokeNative(Native Method)
     [exec] 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
     [exec] 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
     [exec] 	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
     [exec] 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

that comes from libadblockplus internals.

Change History (7)

comment:1 Changed 2 years ago by asmirnov

  • Cc sergz added

comment:2 Changed 2 years ago by asmirnov

  • Blocked By 4207 added

comment:3 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4202 - Fix failing AndroidWebRequestTest.testXMLHttpRequest

comment:5 Changed 4 weeks ago by asmirnov

  • Blocked By 4207 removed

Was blocked by issue #4207.

comment:6 Changed 4 weeks ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 4 weeks ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.