Opened 3 years ago

Closed 4 days ago

#4204 closed change (rejected)

Make $genericblock work better

Reported by: fanboy Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: arthur, kzar, sebastian, mapx Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mapx)

Currently $genericblock isn't a very useful filter especially if we're trying to counter Anti-adblock filters. Still unsure how it works properly.

Most sites will use a specific string to check (if not an element). say "/advert.js" http://somesite.com/advert.js

An alternative way $genericblock could work, still block

||filters

(so site specific rules, and

||adserver

rules). But if we add the following

@@||somesite.com^$genericblock

It'll cover any attempt to have revolving filenames matching the generic filters in easylist_general_block.txt

Change History (6)

comment:1 Changed 3 years ago by mapx

  • Description modified (diff)

comment:2 Changed 3 years ago by mapx

  • Description modified (diff)

comment:3 Changed 3 years ago by mapx

  • Cc arthur kzar sebastian trev mapx added

comment:4 Changed 22 months ago by fhd

  • Cc trev removed

comment:5 Changed 4 days ago by greiner

  • Component changed from Unknown to Core

comment:6 Changed 4 days ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.