Opened 3 years ago

Last modified 6 months ago

#4207 new change

Lower case of HTTP header names in compat.js rather than in each implementation module

Reported by: sergz Assignee:
Priority: P5 Milestone:
Module: Libadblockplus Keywords: goodfirstbug
Cc: fhd, asmirnov Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

When the user queries for the header value, the case of header name is lowered , to support it we lower the case in each implementation of HTTP requests (1, 2). It would be better to make the lowering instead in compat.js at least for consistency, so we do the lowering in one place by the same function (String.prototype.toLowerCase).

What to change

  • lower the case of all header names in compat.js
  • remove lowering from WebRequest implementations.

Change History (3)

comment:1 Changed 3 years ago by sergz

  • Summary changed from lower case HTTP header names in compat.js rather than in each implementation module to Lower case of HTTP header names in compat.js rather than in each implementation module

comment:2 Changed 3 years ago by asmirnov

  • Blocking 4202 added

comment:3 Changed 6 months ago by asmirnov

  • Blocking 4202 removed
Note: See TracTickets for help on using tickets.