Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4211 closed defect (fixed)

Element hiding doesn't work under certain conditions

Reported by: arthur Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By: #4251
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29347936/

Description (last modified by trev)

Environment

Windows 10 Pro
ABP 2.7.3.4186
EasyList
Tested with Firefox 47.0.1, 48 Beta 4 and latest Nightly

How to reproduce

  1. Go to https://www.rt.com/op-edge/345470-nsa-leaks-snowden-whistleblower/ and scroll down to the first embedded YouTube video
  2. Click on it's title "Snowden leaks lead to legal reforms, not just public awareness"

Observed behaviour

While element hiding seems to work fine on rt.com, on YouTube it doesn't. You can see the advertising label in the right sidebar at the top and the yellow mark at the beginning of the seek bar. Those two elements are usually hidden in EasyList.

Expected behaviour

The two elements shouldn't be visible.

Background

This is similar to #4243. While we don't get an exception here, the page's URL is reported as about:blank - it isn't really initialized when we look at it.

Change History (7)

comment:1 Changed 3 years ago by trev

  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed 3 years ago by trev

  • Description modified (diff)
  • Owner set to trev

comment:3 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 years ago by trev

  • Blocked By 4251 added

comment:7 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Element hiding looks to be working as expected in general and with the steps/example above.

ABP 2.7.3.4198-beta
Firefox 38 / 48 / Windows 7
Nightly 51.0a1 / Windows 7

Note: See TracTickets for help on using tickets.